fix: render task list markers correctly with Comark#2576
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
Member
|
Thank you for the contribution. I think it may be better to propose a fix on the Comark side, like comarkdown/markdown-it-comark#29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[x]/[ ]markers are removed after checkboxes are created.Fixes #2568
Test plan
pnpm exec vitest run packages/slidev/node/syntax/task-list.test.tspnpm exec vitest run packages/slidev/node/syntaxpnpm exec eslint packages/slidev/node/syntax/index.ts packages/slidev/node/syntax/task-list.ts packages/slidev/node/syntax/task-list.test.tspnpm --filter @slidev/cli buildgit diff --check